@flyfloh have you already tried setting services.nginx.recommendedProxySettings = true;?

@aanderse Sorry, took a while until I found some time to try this. Unfortunately setting recommendedProxySettings breaks when there are other virtual hosts configured on the same machine and renders airsonic completely inaccessible.

No problem. This looks fine to me then. We should find someone familiar with nginx to approve this and then we can merge 👍

@aanderse Sorry, took a while until I found some time to try this. Unfortunately setting recommendedProxySettings breaks when there are other virtual hosts configured on the same machine and renders airsonic completely inaccessible.

It seems all right to use their settings, though I wonder what's going on here: what if other services are affected as well?
A diff between ours recommendedProxySettings and airsonic recommendation shows that:

1. we set an extra Accept-Encoding "", probably unrelated
2. they set proxy_max_temp_file_size 0, probably unrelated
3. we set an extra X-Forwarded-Server $host, not sure but probably harmless
4. finally, we disagree on the value of X-Forwarded-Host: we use $host while they use $http_host.

The nginx docs says the following about $host

in this order of precedence: host name from the request line, or host name from the “Host” request header field, or the server name matching a request

On the other hand $http_host:

The value of the HTTP request header HOST when converted to lowercase and with 'dashes' converted to 'underscores'

The two could be different and thus break the connection if

• The server is not on port 80 or 443, or
• The virtual host has several names

ping @flyfloh

I couldn't reproduce the breakage when using recommendedProxySettings when trying to investigate this further just now. Since everything works with that setting now I have updated this PR to use it.

So, can we go forward with this? Should it be backported?

Everything still works from my side. Is there anything I need to do before this can be merged?

Since @Ma27 approved of this and you can't reproduce the issue with recommendedProxySettings I think it's good to go.

Backported to 20.03 in e393449.